Messages in this thread | | | Date | Sun, 06 Jul 2008 09:45:56 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH #upstream-fixes] ahci: give another shot at clearing all bits in irq_stat |
| |
Tejun Heo wrote: > Commit ea0c62f7cf70f13a67830471b613337bd0c9a62e tried to clear all > bits in irq_stat but it didn't actually achieve that as irq_stat was > anded with port_map right after read. This patch makes ahci driver > always use the unmasked value to clear irq_status. > > While at it, add explanation on the peculiarities of ahci IRQ > clearing. > > This was spotted by Linus Torvalds. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Cc: Linus Torvalds <torvalds@linux-foundation.org> > --- > The original report requires further investigation regarding why the > bogus change fixed the problem but this change is the correct thing to > do regardless. > > Thanks.
Belated post-holiday ACK (since it's already in).
Thanks for taking care of this, and good catch too.
| |