Messages in this thread | | | Date | Sat, 05 Jul 2008 21:14:00 -0700 (PDT) | Subject | Re: [NET-NEXT PATCH 08/18] igb: Introduce multiple TX queues with infrastructure | From | David Miller <> |
| |
From: Jeff Garzik <jeff@garzik.org> Date: Fri, 04 Jul 2008 08:43:10 -0400
> Jeff Kirsher wrote: > > From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> > > > > This code adds multiple Tx queue infrastructure much like we > > previously did in ixgbe. The MSI-X vector mapping is the bulk of > > the change. > > > > IAM can now be safely enabled and we've verified that it does > > work correctly. We can also eliminate the tx ring lock. > > > > Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> > > Signed-off-by: Mitch Williams <mitch.a.williams@intel.com> > > Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com> > > --- > > > > drivers/net/igb/igb.h | 6 +- > > drivers/net/igb/igb_main.c | 160 ++++++++++++++++++++++++++++++-------------- > > 2 files changed, 113 insertions(+), 53 deletions(-) > > presumably this should wait for david to finish his multi-TX stuff?
Adding infrastructure now is a good thing. I did something similar for NIU, and the Broadcom folks have done similar for bnx2*.
That's why the NIU multiqueue TX patch in my series was only 10 lines of changes, all the infrastructure and init was in the driver already :-)
| |