lkml.org 
[lkml]   [2008]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ieee1394 : dump mmapped video1394 buffers in core files
    Philippe De Muyter wrote:
    > Currently, core files do not contain the mmapped memory of the video1394
    > or dv1394 devices,

    Ditto with /dev/raw1394 when the rawiso ioctl API is used.

    > which contain the actual video input, making it
    > impossible to analyse the cause of abnormal program termination for
    > image analysis or (de)compression software. Fix that.
    >
    > Signed-off-by: Philippe De Muyter <phdm@macqel.be>
    > ---
    > diff -r ced66ca0044f drivers/ieee1394/dma.c
    > --- a/drivers/ieee1394/dma.c Mon Jun 30 08:58:09 2008 -0700
    > +++ b/drivers/ieee1394/dma.c Thu Jul 3 18:40:24 2008 +0200
    > @@ -274,7 +274,7 @@ int dma_region_mmap(struct dma_region *d
    > vma->vm_ops = &dma_region_vm_ops;
    > vma->vm_private_data = dma;
    > vma->vm_file = file;
    > - vma->vm_flags |= VM_RESERVED;
    > + vma->vm_flags |= VM_RESERVED | VM_ALWAYSDUMP;
    >
    > return 0;
    > }

    I'll commit it with the title changed to "dump mmapped iso buffers in
    core files" if that's OK.
    --
    Stefan Richter
    -=====-==--- -=== --=--
    http://arcgraph.de/sr/


    \
     
     \ /
      Last update: 2008-07-04 20:35    [W:3.952 / U:0.268 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site