Messages in this thread | | | Date | Fri, 4 Jul 2008 19:45:56 +0200 | From | Pierre Ossman <> | Subject | Re: [PATCH v2 2/4] mmc: Export internal host state through debugfs |
| |
On Tue, 1 Jul 2008 15:14:52 +0200 Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:
> When CONFIG_DEBUG_FS is set, create a few files under /sys/kernel/debug > containing information about an mmc host's internal state. Currently, > just a single file is created, "ios", which contains information about > the current operating parameters for the bus (clock speed, bus width, > etc.) > > Host drivers can add additional files and directories under the host's > root directory by passing the debugfs_root field in struct mmc_host as > the 'parent' parameter to debugfs_create_*. > > Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com> >
I see that this version has no ifdef:s at all. Doesn't that mean a lot of useless code if DEBUG_FS is not enabled? You embedded guys are usually rather sensitive about such things. :)
-- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. [unhandled content-type:application/pgp-signature] | |