Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH] fix build error of driver/mfd/tc6393xb.c | Date | Fri, 4 Jul 2008 09:50:17 -0700 |
| |
On Friday 04 July 2008, Takashi Iwai wrote: > > > The proper fix probably is to make PPC_MPC5200_GPIO also select > > GENERIC_GPIO.
I think it's higher in the dependency tree than that.
> > I don't think that building GPIO_LIB w/o GENERIC_GPIO > > should be supported. > > [Added David to Cc] > > Then HAVE_GPIO_LIB should depend on GENERIC_GPIO.
They must go together ... right. Anything using gpiolib without the interface it implements needs a head-exam. ;)
But since ISTR that Kconfig (still) doesn't get dependencies right when you "select" something that depends on something else, that particular solution won't fly.
> Or, linux/gpio.h should be fixed so that the code can be built > properly without GENERIC_GPIO.
No; GENERIC_GPIO is the interface, HAVE_GPIO_LIB is one of the valid ways to implement it.
It should work if HAVE_GPIO_LIB selected GENERIC_GPIO...
- Dave
| |