Messages in this thread | | | Date | Thu, 31 Jul 2008 07:52:42 +1000 (EST) | From | James Morris <> | Subject | Re: [patch] vfs: make security_inode_setattr() calling consistent |
| |
On Wed, 30 Jul 2008, Stephen Smalley wrote:
> Unfortunate since we'd prefer to have the DAC checks applied first, and > since inode_change_ok() may alter the ia_mode in response to those > checks, but it does seem inconsistent at present and it doesn't yield > any difference in the ltp selinux testsuite results.
No LSM seems to be using ia_mode, so that aspect is ok. The DAC checks are generally not being applied first currently, so common case behaviour doesn't change with this patch.
Acked-by: James Morris <jmorris@namei.org>
-- James Morris <jmorris@namei.org>
| |