Messages in this thread | | | Date | Wed, 30 Jul 2008 22:47:07 +0200 | From | Bernhard Walle <> | Subject | Re: [PATCH 2/2] firmware/memmap: Move kobject initialisation before kobject_add() |
| |
* Andrew Morton <akpm@linux-foundation.org> [2008-07-30 13:40]: > > If you think that "firmware/memmap: Move kobject initialisation before > kobject_add()"
Yes, that's what I meant.
> should still be applied then I'd disagree. Adding a > GFP_KERNEL allocation into kobject_init() was a fairly significant > backward step. It's _good_ that kobject_init() can be called this > early. Let us strive to retain that robustness.
Ok, since you have more experience with kobject, I'm fine with not applying that one.
[I saw you merged the first (coding style) patch.]
Bernhard -- Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
| |