lkml.org 
[lkml]   [2008]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: RFC [PATCH] x86: introduce nr_irqs for 64bit
    Ingo Molnar wrote:
    > * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
    >
    >> add DEFINE_DYN_ARRAY for dynamical array support
    >>
    >> todo:
    >> 1. convert x86 32bit and other arch
    >> 2. nr_irqs auto probe via acpi_oem_check?
    >>
    >> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
    >
    > wonderful!
    >
    > I have one main structural suggestion: could we please keep the NR_IRQS
    > name, and just change it to dynamic on x86? NR_IRQS is used in 540
    > places in the kernel, there's no point in touching all that code.

    Good thought.
    >
    > Also add an CONFIG_ARCH_HAS_DYNAMIC_NR_IRQS switch, define it in
    > arch/x86/Kconfig and use it in include/linux/irq.h.

    It could also revert DEFINE_DYN_ARRAY to a fixed array for more
    compact code in small machines.

    Thanks,
    Mike
    >
    > This will create far less migration pain than the widespread rename.
    > That will also solve the "what about the other architectures" question.
    >
    > Ingo



    \
     
     \ /
      Last update: 2008-07-30 15:01    [W:5.767 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site