lkml.org 
[lkml]   [2008]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/04] s390: bus_id -> dev_name conversions
On Wed, Jul 02, 2008 at 11:49:43AM -0700, Greg KH wrote:
> On Wed, Jul 02, 2008 at 06:28:32PM +0200, Cornelia Huck wrote:
> > On Wed, 2 Jul 2008 08:46:30 -0700,
> > Greg KH <greg@kroah.com> wrote:
> >
> > > @@ -529,7 +529,7 @@ cio_validate_subchannel (struct subchann
> > > }
> > > mutex_init(&sch->reg_mutex);
> > > /* Set a name for the subchannel */
> > > - snprintf (sch->dev.bus_id, BUS_ID_SIZE, "0.%x.%04x", schid.ssid,
> > > + snprintf (dev_name(&sch->dev), BUS_ID_SIZE, "0.%x.%04x", schid.ssid,
> > > schid.sch_no);
> > >
> > > /*
> >
> > This hunk does not make much sense. Better just leave it alone until
> > the dev_set_name()/init_name conversion later.
>
> You are right.
>
> 390 maintainers, can you drop this hunk, or do you want me to respin it
> and the other 3 patches (if needed)?

Please resend, since patch 2 needs to be changed as well, right?

Thanks! :)


\
 
 \ /
  Last update: 2008-07-03 17:21    [W:0.030 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site