Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [Bug 10868] Oops on loading ipaq module since 2.6.26, prevents use of device | Date | Thu, 3 Jul 2008 16:08:44 +0200 |
| |
Am Donnerstag 03 Juli 2008 10:57:33 schrieb Adrian Bunk: > On Thu, Jul 03, 2008 at 10:05:57AM +0200, Oliver Neukum wrote:
> > As far as I can tell somebody changed the ipaq driver in 2.6.26-rc6. I cannot > > find the exact patch that did it in Greg's directory. As it causes a regression > > here's a reversal. > > > It was changed by:
Thanks, did you do git magic?
> commit e1879b19b0abdb387e4aeb0b935a486cc75042fb > Author: Matthias Geissert <matthias.geissert@web.de> > Date: Thu Mar 6 22:00:33 2008 +0100 > > USB: ipaq: fix devices having more than one endpoint > > The ipaq module supports devices with one endpoint only. Some devices, > e.g. Yakumo Delta 300, have more than one endpoint. > > This patch fixes support for devices having up to 2 endpoints which used > to work on older kernel versions. > > Signed-off-by: Matthias Geissert <matthias.geissert@web.de> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> > > diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c > index 9b38a08..17f2a53 100644 > --- a/drivers/usb/serial/ipaq.c > +++ b/drivers/usb/serial/ipaq.c > @@ -571,9 +571,9 @@ static struct usb_serial_driver ipaq_device = { > .usb_driver = &ipaq_driver, > .id_table = ipaq_id_table, > .num_interrupt_in = NUM_DONT_CARE, > - .num_bulk_in = 1, > - .num_bulk_out = 1, > - .num_ports = 1, > + .num_bulk_in = NUM_DONT_CARE, > + .num_bulk_out = NUM_DONT_CARE,
This is good.
> + .num_ports = 2,
This is fatal.
The patch I sent reverts only this part, so this issue is solved.
Regards Oliver
| |