Messages in this thread Patch in this message | | | Subject | Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" | From | David Woodhouse <> | Date | Thu, 03 Jul 2008 14:52:55 +0100 |
| |
On Thu, 2008-07-03 at 09:38 -0400, Jeff Garzik wrote: > David Woodhouse wrote: > >> dwmw2 has been told repeatedly that his changes will cause PRECISELY > >> these problems, but he refuses to take the simple steps necessary to > >> ensure people can continue to boot their kernels after his changes go in. > > > > Complete nonsense. Setting CONFIG_FIRMWARE_IN_KERNEL isn't hard. But > > shouldn't be the _default_, either. > > > >> Presently his tg3 changes have been nak'd, in part, because of this > >> obviously, forseeable, work-around-able breakage. > > > > They haven't even been reviewed. Nobody seems to have actually looked at > > > Yes, they have. You just didn't like the answers you received.
I received no comment on any part of the changes within tg3.c; only whining about the default behaviour -- which isn't even _set_ as part of the patch in question, any more.
> In particular, the Kconfig default for built-in tg3 firmware should > result in the current behavior, without the user having to take extra steps.
After feedback from a number of people, there is no individual Kconfig option for the various firmwares; there is only one which controls them all -- CONFIG_FIRMWARE_IN_KERNEL. The thing you're whining about isn't even part of the patch which needs review.
> Because of your stubborn refusal on this Kconfig defaults issue, WE > ALREADY HAVE DRIVER-DOES-NOT-WORK BREAKAGE, JUST AS PREDICTED.
I strongly disagree that CONFIG_FIRMWARE_IN_KERNEL=y should be the default. But if I add this patch elsewhere in the kernel, will you quit your whining and actually review the patch you were asked to review? ...
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 339c148..d47482f 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -37,6 +37,7 @@ config FW_LOADER config FIRMWARE_IN_KERNEL bool "Include in-kernel firmware blobs in kernel binary" depends on FW_LOADER + default y help The kernel source tree includes a number of firmware 'blobs' which are used by various drivers. The recommended way to -- dwmw2
| |