lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] powerpc/lpar - defer prefered console setup
    On Tue, Jul 29, 2008 at 05:43:24PM +1000, Benjamin Herrenschmidt wrote:
    > On Tue, 2008-07-29 at 09:36 +0200, Bastian Blank wrote:
    > > On Tue, Jul 29, 2008 at 01:06:18PM +1000, Benjamin Herrenschmidt wrote:
    > > > On Mon, 2008-07-28 at 20:56 +0200, Bastian Blank wrote:
    > > > > Hi
    > > > >
    > > > > The powerpc lpar code adds a prefered console at a very early state,
    > > > > during arch_setup. This runs even before the console setup from the
    > > > > command line and takes preference.
    > > > >
    > > > > This patch moves the prefered console setup into an arch_initcall which
    > > > > runs later and allows the specification of the correct console on the
    > > > > command line. The udbg console remains as boot console.
    > > > >
    > > > Shouldn't it be a console_initcall() ?
    > >
    > > No. console_initcall is for the initial console setup and runs way long
    > > before the command line setup. It needs to run after that.
    >
    > Hrm... we do most of the console discovery from console_initcall for
    > legacy UARTs. see the code in legacy_serial.c, we just avoid doing
    > the add_preferred_console() thingy if there's a console= on the command
    > line :-)

    The code did that, but the check was removed because it trips on
    netconsole=. See 5faae2e5d1f53df9dce482032c8486bc3a1feffc.

    Bastian

    --
    The heart is not a logical organ.
    -- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4


    \
     
     \ /
      Last update: 2008-07-29 10:11    [W:4.911 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site