lkml.org 
[lkml]   [2008]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: pci_ids.h - duplicate entry and many out of order definitions
Date
On Wed, 30 Jul 2008 09:00:09 +1000, "David Wilson" <mcs6502@gmail.com> wrote:

>I was browsing the pci_ids.h file and came across a duplicate entry
>for PCI_VENDOR_ID_RDC. This prompted me to look further and I found a
>number of out-of-order definitions (based on the comment at the head
>of the file that indicates that they should be sorted). I decided to
>write a script to check this and it found 74 "errors".
>
>1) Is it worth my time generating a patch to fix all these mis-orderings?
>2) Should it be one large patch or many small ones (eg one per PCI_VENDOR)?
>3) Is there a maintainer for this file?

Dunno about a maintainer, I did a cleanup over the thing a couple years
ago and GregKH was taking the patches.

Also need to check that people not making PCI_* names up with macros in
drivers as that reduces grep usability.

Think there's a new PCI maintainer now?

Grant.


\
 
 \ /
  Last update: 2008-07-30 01:47    [W:0.036 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site