Messages in this thread | | | Date | Tue, 29 Jul 2008 19:27:59 +0900 | Subject | Re: [PATCH] add iommu_num_pages helper function | From | FUJITA Tomonori <> |
| |
On Tue, 29 Jul 2008 03:10:05 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> From: Joerg Roedel <joerg.roedel@amd.com> > Date: Tue, 29 Jul 2008 11:50:27 +0200 > > > I think moving that function to x86-only code is the best solution for > > now. Before moving it back to generic code we need an architecture > > independent way to find out the IOMMU page size. > > My suggestion (again) is to pass it in as a "const unsigned long > io_page_size" argument and update the callers.
Either is fine by me.
Joerg, if you like, please finish this (for all the architectures, please). As I said before, I planed to work on this cleanup after rc1 (and this should have been 2.6.28 stuff). But I'd appreciate if you would do.
Thanks,
| |