Messages in this thread | | | Date | Tue, 29 Jul 2008 08:57:27 +0900 | From | Paul Mundt <> | Subject | Re: [PATCH] sh/maple: clean maple bus code |
| |
On Tue, Jul 29, 2008 at 12:44:16AM +0100, Adrian McMenamin wrote: > static struct mapleq *maple_allocq(struct maple_device *mdev) > { > struct mapleq *mq; > > mq = kmalloc(sizeof(*mq), GFP_KERNEL); > if (!mq) > - return NULL; > + goto failed_nomem; > > mq->dev = mdev; > mq->recvbufdcsp = kmem_cache_zalloc(maple_queue_cache, GFP_KERNEL); > mq->recvbuf = (void *) P2SEGADDR(mq->recvbufdcsp); > - if (!mq->recvbuf) { > - kfree(mq); > - return NULL; > - } > + if (!mq->recvbuf) > + goto failed_p2;
This is really the wrong thing to check, you want to be checking mq->recvbufdcsp here, as kmem_cache_zalloc() will return an error, while P2SEGADDR() casts away. I expect that if you toss a NULL pointer or something similar at it you will just get the P2 base back anyways, it was never intended for error cases.
I expect you will also want to document your locking strategy in detail at the top of the file. You do have some corner cases that are handled that are not immediately obvious at first glance, it would be good to spell it out explicitly.
| |