Messages in this thread | | | Date | Mon, 28 Jul 2008 09:57:51 +0200 | From | Clemens Ladisch <> | Subject | Re: [patch 2.6.26-git] /dev/hpet - fixes and cleanup |
| |
David Brownell wrote: > ... > Plus, add a FIXME comment for something that could cause big trouble > on systems with more capable HPETs than at least Intel seems to ship. > ... > + > + /* FIXME this may trash both the system clocksource and > + * the current clock event device! Use HPET_TN_SETVAL > + * instead, like arch/x86/kernel/hpet.c does ... never > + * modify the counter, ever. > + */ > m = read_counter(&hpet->hpet_mc); > write_counter(t + m + hpetp->hp_delta, &timer->hpet_compare);
This comment seems to assume that the code below modifies the main counter, which it doesn't. Additionally, HPET_TN_SETVAL has the same value as Tn_VAL_SET_CNF_MASK (from <linux/hpet.h>), which _is_ used.
Regards, Clemens
| |