Messages in this thread | | | Date | Sat, 26 Jul 2008 01:26:01 -0700 (PDT) | From | Trent Piepho <> | Subject | Re: [RFC PATCH] of_gpio: implement of_get_gpio_flags() |
| |
On Fri, 25 Jul 2008, Anton Vorontsov wrote: > > The name seems a bit unfortunate though, because one could read the > function as it gets gpio flags only (though, we might implement > this instead, but this way average driver will end up with parsing > gpios = <> twice).
It is kind of a confusing name. I'd be tempted to just change of_get_gpio, it's a new function and it's only called from four places so it's not that hard to change.
| |