lkml.org 
[lkml]   [2008]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] nwflash: fix build errors and warning
On Sun, Jul 27, 2008 at 12:02:20AM +0900, Akinobu Mita wrote:
> On Sat, Jul 26, 2008 at 03:18:08PM +0100, Russell King - ARM Linux wrote:
> > On Fri, Jul 25, 2008 at 01:48:18AM -0700, akpm@linux-foundation.org wrote:
> > > From: Akinobu Mita <akinobu.mita@gmail.com>
> > >
> > > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> > > Cc: Russell King <linux@arm.linux.org.uk>
> > > Cc: Tim Schmielau <tim@physik3.uni-rostock.de>
> > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> >
> > Argh... Are people now submitting untested patches as a rule?
> >
> > drivers/char/nwflash.c: In function 'flash_read':
> > drivers/char/nwflash.c:129: error: 'p' undeclared (first use in this function)
> > drivers/char/nwflash.c:129: error: (Each undeclared identifier is reported only once
> > drivers/char/nwflash.c:129: error: for each function it appears in.)
> > drivers/char/nwflash.c:129: error: 'count' undeclared (first use in this function)
> > drivers/char/nwflash.c:136: warning: passing argument 4 of 'simple_read_from_buffer' discards qualifiers from pointer target type
> > make[2]: *** [drivers/char/nwflash.o] Error 1
> > make[1]: *** [drivers/char] Error 2
> > make: *** [drivers] Error 2
>
> Sorry. I'm preparing cross compiler. But this patch should fix this
> problem.

I sort of did the same - but merely changing the names of the variables
generates other warnings. More complete (and build-tested) commit
queued up:

http://ftp.arm.linux.org.uk/git/gitweb.cgi?p=linux-2.6-arm.git;a=commitdiff;h=4ef584ba84125b67c17b5aded38e7783cd8cdef0


\
 
 \ /
  Last update: 2008-07-26 17:41    [W:0.041 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site