lkml.org 
[lkml]   [2008]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/3] mmc: Add per-card debugfs support
    On Fri, 25 Jul 2008 11:05:03 +0200
    Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:

    > On Fri, 25 Jul 2008 09:24:24 +0100
    > Ben Dooks <ben-linux@fluff.org> wrote:
    >
    > > out of interest, why not have an standard sysfs node for the
    > > current voltage setting?
    >
    > Dunno. Because nobody has added it? ;-)
    >

    It is also a stable userspace ABI at that point, so it needs to be done
    a lot more carefully.

    > >
    > > why not make mmc_add_card_debugfs() an empty function
    > > in the header if there is no debugfs support?
    >
    > Because Pierre didn't like it.
    >

    If it's just in core.h, then I can live with it. I did not like it when
    it added even more noise to the core .c files.

    Rgds
    --
    -- Pierre Ossman

    Linux kernel, MMC maintainer http://www.kernel.org
    rdesktop, core developer http://www.rdesktop.org

    WARNING: This correspondence is being monitored by the
    Swedish government. Make sure your server uses encryption
    for SMTP traffic and consider using PGP for end-to-end
    encryption.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2008-07-25 12:07    [W:5.296 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site