lkml.org 
[lkml]   [2008]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2.6.26-git] pm selftest: rtc paranoia
On Fri, 25 Jul 2008 13:26:51 -0700
David Brownell <david-b@pacbell.net> wrote:

> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Cope with a quirk of some RTCs (notably ACPI ones) which
> aren't guaranteed to implement oneshot behavior when they
> woke the system from sleeep: forcibly disable the alarm,
> just in case.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> kernel/power/main.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> --- a/kernel/power/main.c 2008-07-22 16:38:32.000000000 -0700
> +++ b/kernel/power/main.c 2008-07-22 16:39:15.000000000 -0700
> @@ -635,6 +635,13 @@ static void __init test_wakealarm(struct
> }
> if (status < 0)
> printk(err_suspend, status);
> +
> + /* Some platforms can't detect that the alarm triggered the
> + * wakeup, or (accordingly) disable it after it afterwards.
> + * It's supposed to give oneshot behavior; cope.
> + */
> + alm.enabled = false;
> + rtc_set_alarm(rtc, &alm);
> }
>
> static int __init has_wakealarm(struct device *dev, void *name_ptr)

I assume this fixes some reported bug? Any references?

Is this needed in 2.6.26.x? 2.6.25.x?


\
 
 \ /
  Last update: 2008-07-25 23:53    [W:3.210 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site