Messages in this thread | | | Date | Fri, 25 Jul 2008 11:29:42 +0800 | From | Li Zefan <> | Subject | Re: [PATCH 2/2[ Traffic control cgroups subsystem |
| |
Daniel Walker wrote: > On Thu, 2008-07-24 at 16:37 -0700, Ranjit Manomohan wrote: > > >> +/* Delete one filter entry */ >> +static int cgroup_delete(struct tcf_proto *tp, unsigned long arg) >> +{ >> + struct cgroup_head *head = (struct cgroup_head *) tp->root; >> + struct cgroup_filter *t, *f = (struct cgroup_filter *) arg; >> + >> + list_for_each_entry(t, &head->flist, link) >> + if (t == f) { >> + tcf_tree_lock(tp); >> + list_del(&t->link); > > Doesn't the above need to be a "_safe" list operation since your > deleting the element? >
No. You don't need "_safe" if you break out the loop immediately after list_del().
| |