lkml.org 
[lkml]   [2008]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 4/4] remove <linux/hdreg.h>
Date
On Thursday 24 July 2008, Christoph Hellwig wrote:
> On Thu, Jul 24, 2008 at 09:37:58PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > It has no in-kernel users now and can be removed.
>
> But beeing an exported header it has userspace users. Plese keep it
> and just leave the ioctl defintions as need by userspace in it instead
> of renaming that part to hdio_ioctls.h.

Agreed w.r.t. to keeping it (the last patch was more of rfc than intended
to be commited, sorry that I didn't mark it as such) but what's wrong with
moving ioctl definitions to hdio_ioctls.h so we have clean separation of
obsoleted userspace-only stuff & userspace/kernel stuff?

[ The hdio_ioctls.h include is also exported to userspace and included
by hdreg.h internally (patch #1) so userspace should be unaffected. ]

Thanks,
Bart


\
 
 \ /
  Last update: 2008-07-24 22:21    [W:0.037 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site