Messages in this thread | | | Date | Fri, 25 Jul 2008 00:35:26 +0900 (JST) | Subject | Re: [patch 29/29] initrd: Fix virtual/physical mix-up in overwrite test | From | Atsushi Nemoto <> |
| |
On Thu, 17 Jul 2008 21:16:36 +0200, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > if (initrd_start && !initrd_below_start_ok && > - initrd_start < min_low_pfn << PAGE_SHIFT) { > + page_to_pfn(virt_to_page(initrd_start)) < min_low_pfn) { > printk(KERN_CRIT "initrd overwritten (0x%08lx < 0x%08lx) - " > - "disabling it.\n",initrd_start,min_low_pfn << PAGE_SHIFT); > + "disabling it.\n", > + page_to_pfn(virt_to_page(initrd_start)), min_low_pfn); > initrd_start = 0; > }
This patch causes warnings on mips:
linux/init/main.c: In function 'start_kernel': linux/init/main.c:633: warning: passing argument 1 of 'virt_to_phys' makes pointer from integer without a cast linux/init/main.c:636: warning: passing argument 1 of 'virt_to_phys' makes pointer from integer without a cast
Because an argument of mips virt_to_phys() is an pointer and initrd_start is unsigned long. It seems most (all?) arch's virt_to_phys() casts its argument to unsigned long internally. Should mips follow?
--- Atsushi Nemoto
| |