lkml.org 
[lkml]   [2008]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86 (64): make calibrate_APIC_clock() SMI-safe
Hi Cyrill,

> btw, Martin, don't get me wrong please - i'm not just complaining :)
> The changes you propose is important enough _but_ it could introduce
> regression. Look, with situation of miscalibrated apic timer kernel
> was working before but with the patch it could stop to work. So if
> user has a such screwed motherboard he could be shocked if it stop
> booting with message about SMI happened. we defenitely have to provide
> some workaround for this. And your max iteration counter solution
> would be fine I think.

Let's see what other people think about this. I am fine with both
solutions. Currently only the first one has been tested though (testing
these patches thoroughly needs long-time reboot tests).

One more remark: There are similar calibration routines around in the
kernel which suffer from similar problems as calibrate_APIC_clock().
AFAIK, only calibrate_delay() was made SMI-safe by Venkatesh Pallipadi
years ago.

Martin

--
Martin Wilck
PRIMERGY System Software Engineer
FSC IP ESP DEV 6

Fujitsu Siemens Computers GmbH
Heinz-Nixdorf-Ring 1
33106 Paderborn
Germany

Tel: ++49 5251 8 15113
Fax: ++49 5251 8 20209
Email: mailto:martin.wilck@fujitsu-siemens.com
Internet: http://www.fujitsu-siemens.com
Company Details: http://www.fujitsu-siemens.com/imprint.html


\
 
 \ /
  Last update: 2008-07-24 17:17    [W:0.239 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site