Messages in this thread | | | Date | Wed, 23 Jul 2008 16:21:42 -0700 | From | Greg KH <> | Subject | Re: [PATCH] x86: usb debug port early console v2 |
| |
On Wed, Jul 23, 2008 at 03:54:09PM -0700, Yinghai Lu wrote: > On Wed, Jul 23, 2008 at 3:45 PM, Greg KH <greg@kroah.com> wrote: > > On Wed, Jul 23, 2008 at 02:00:53PM -0700, Yinghai Lu wrote: > >> --- linux-2.6.orig/drivers/usb/host/ehci.h > >> +++ linux-2.6/drivers/usb/host/ehci.h > > > > I don't understand the issue of any of these #ifdefs here. Why are they > > needed? > > In file included from arch/x86/kernel/early_printk.c:19: > arch/x86/kernel/../../../drivers/usb/host/ehci.h:109: error: field > 'iaa_watchdog' has incomplete type
Ah, so you are papering over the real problem here, right?
Why not just include the properly needed #includes either where you are including this header file, or add the dependancies to the ehci.h file itself (which is usually preferred.)
> > And shouldn't there be a separate config option for early printk through > > the ehci debug port? > > under usb or processor?
Somewhere.
Also, usb patches should be cc:ed to the linux-usb mailing list. I'm sure the EHCI authors would like to comment on this patch...
thanks,
greg k-h
| |