Messages in this thread | | | Date | Wed, 23 Jul 2008 13:55:30 -0700 (PDT) | Subject | Re: Kernel WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98() | From | David Miller <> |
| |
From: Jarek Poplawski <jarkao2@gmail.com> Date: Wed, 23 Jul 2008 22:43:35 +0200
> On Wed, Jul 23, 2008 at 01:16:07PM -0700, David Miller wrote: > ... > > There will always be a need for a "stop all the TX queues" operation. > > The question is if the current way is "all correct". As a matter of > fact I think Peter's doubts could be justified: taking "USHORT_MAX" > locks looks really dubious (so maybe it's not so strange lockdep > didn't get used to this).
There are, of course, potentially other ways to achieve the objective.
And for non-multiqueue aware devices (which is the vast majority of the 400 or so networking drivers we have) there is only one queue and thus one lock taken.
| |