lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: more header fixes

* Vegard Nossum <vegard.nossum@gmail.com> wrote:

> On Wed, Jul 16, 2008 at 4:22 PM, Ingo Molnar <mingo@elte.hu> wrote:
> >> I'm not sure how we should proceed with this. On one hand, we could
> >> just fix the issues as they come up and be done with it. On the other
> >> hand, this was exactly the thing I wanted to avoid by automatic it. I
> >> guess it can never be fully automated... The question is if there is
> >> any danger of *silent* (read: runtime) breakage, which would be much
> >> worse than compiler errors.
> >
> > dont worry, lets fix the above hideous hack first, then i can merge the
> > guards fixes ontop of that fix. That's why we do testing, to catch the
> > cases where assumptions fail. Your script is just fine - it beats having
> > to edit 280+ files by hand ...
>
> I've updated my script to also fix any rogue uses of header-guard
> names in auxiliary files. I'm attaching the resulting patch.
>
> It doesn't really _fix_ the hideous hack, it merely unbreaks it.
>
> Patch #2 also fixes some left-over headers. They both apply on top of
> tip/x86/header-guards.

looks good - do you have a branch i could pull into
tip/x86/header-guards?

Ingo


\
 
 \ /
  Last update: 2008-07-22 12:39    [W:0.063 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site