Messages in this thread | | | Date | Wed, 02 Jul 2008 16:32:06 +0800 | From | Wang Chen <> | Subject | Re: [PATCH 2/2] kobjects: Transmit return value of kobject_uevent_env() to caller |
| |
Cornelia Huck said the following on 2008-7-1 18:51: > On Wed, 25 Jun 2008 17:08:37 +0800, > Wang Chen <wangchen@cn.fujitsu.com> wrote: > >> It's depended on how important sending uevent is. >> If the sysfs operation succeeds, but user-space don't >> get the notification. Is it ok? > > Given that (a) there may be no listener, (b) sending via netlink may > succeed but calling uevent_helper may fail (highly unlikely the way > modern distros are set up, though), and (c) you would have to audit a > myriad places that don't check for the return code of kobject_uevent() > today as well, it looks like the best way is to simply add some > pr_debug()s to kobject_uevent_env() where something fails. >
Fair enough. Thanks Cornelia. Greg, please ignore this patch. But please take a look at "[PATCH 1/2] kobjects: Transmit return value of call_usermodehelper() to caller".
| |