Messages in this thread | | | Date | Sat, 19 Jul 2008 21:12:56 +0900 | Subject | Re: [PATCH] replace CONFIG_IOMMU with CONFIG_GART_IOMMU in iommu.h | From | FUJITA Tomonori <> |
| |
On Fri, 18 Jul 2008 13:31:05 +0200 Joerg Roedel <joro@8bytes.org> wrote:
> On Wed, Jul 09, 2008 at 04:29:41PM +0900, FUJITA Tomonori wrote: > > Should be CONFIG_GART_IOMMU instead of CONFIG_IOMMU here? > > > > Hmm, looks like it would be nice to have more cleanups of iommu.h and > > gart.h. > > > > This is against tip/master. > > > > = > > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> > > Subject: [PATCH] replace CONFIG_IOMMU with CONFIG_GART_IOMMU in iommu.h > > > > Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> > > --- > > include/asm-x86/iommu.h | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/include/asm-x86/iommu.h b/include/asm-x86/iommu.h > > index 07862fd..cb7e989 100644 > > --- a/include/asm-x86/iommu.h > > +++ b/include/asm-x86/iommu.h > > @@ -5,7 +5,7 @@ extern void pci_iommu_shutdown(void); > > extern void no_iommu_init(void); > > extern int force_iommu, no_iommu; > > extern int iommu_detected; > > -#ifdef CONFIG_IOMMU > > +#ifdef CONFIG_GART_IOMMU > > extern void gart_iommu_init(void); > > extern void gart_iommu_shutdown(void); > > extern void __init gart_parse_options(char *); > > The asm-x86/iommu.h file is a leftover from some patches I submitted > last year. I renamed iommu.h to gart.h but somehow iommu.h still exists > in mainline. I think we should check again if somebody is using that > file and remove it if not.
I think that we need a common header file (iommu.h or whatever) for what everyone needs, pci_iommu_shutdown(), no_iommu_init(), etc.
Anyway, I did more cleanups:
http://lkml.org/lkml/2008/7/10/510
or
tip/x86/gart
Let me know if you think we still need cleanups.
Thanks,
| |