lkml.org 
[lkml]   [2008]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] coredump: kill mm->core_done
Date
Hi,

Oleg Nesterov <oleg@tv-sign.ru> writes:

> Now that we have core_state->dumper list we can use it to wake up the
> sub-threads waiting for the coredump completion.
>
> This uglifies the code and .text grows by 47 bytes, but otoh mm_struct
> lessens by sizeof(struct completion). Also, with this change we can
> decouple exit_mm() from the coredumping code.
>
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
>
> include/linux/mm_types.h | 4 +---
> kernel/exit.c | 8 +++++++-
> fs/exec.c | 25 ++++++++++++++++++++++---
> 3 files changed, 30 insertions(+), 7 deletions(-)
>
> --- 26-rc2/include/linux/mm_types.h~5_KILL_CORE_DONE 2008-07-13 18:28:36.000000000 +0400
> +++ 26-rc2/include/linux/mm_types.h 2008-07-15 17:06:58.000000000 +0400
> @@ -229,9 +229,7 @@ struct mm_struct {
>
> unsigned long flags; /* Must use atomic bitops to access the bits */
>
> - /* coredumping support */
> - struct core_state *core_state;
> - struct completion core_done;
> + struct core_state *core_state; /* coredumping support */
>
> /* aio bits */
> rwlock_t ioctx_list_lock; /* aio lock */
> --- 26-rc2/kernel/exit.c~5_KILL_CORE_DONE 2008-07-13 19:58:19.000000000 +0400
> +++ 26-rc2/kernel/exit.c 2008-07-15 17:06:58.000000000 +0400
> @@ -680,7 +680,13 @@ static void exit_mm(struct task_struct *
> if (atomic_dec_and_test(&core_state->nr_threads))
> complete(&core_state->startup);
>
> - wait_for_completion(&mm->core_done);
> + for (;;) {
> + set_task_state(tsk, TASK_UNINTERRUPTIBLE);
> + if (!self.task) /* see coredump_finish() */

kernel/exit.c: In function `exit_mm':
kernel/exit.c:686: error: `self' undeclared (first use in this function)
kernel/exit.c:686: error: (Each undeclared identifier is reported only once
kernel/exit.c:686: error: for each function it appears in.)
make[1]: *** [kernel/exit.o] Error 1

Hannes


\
 
 \ /
  Last update: 2008-07-20 01:35    [W:0.060 / U:2.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site