Messages in this thread | | | Date | Fri, 18 Jul 2008 15:36:42 -0700 | From | Mike Travis <> | Subject | Re: [PATCH 6/8] cpumask: Optimize cpumask_of_cpu in lib/smp_processor_id.c |
| |
Ingo Molnar wrote: > * Ingo Molnar <mingo@elte.hu> wrote: > >> hmmm: >> >>> --- linux-2.6.tip.orig/lib/smp_processor_id.c >>> +++ linux-2.6.tip/lib/smp_processor_id.c >>> unsigned long preempt_count = preempt_count(); >>> int this_cpu = raw_smp_processor_id(); >>> - cpumask_t this_mask; >>> + cpumask_of_cpu_ptr_declare(this_mask); >>> - this_mask = cpumask_of_cpu(this_cpu); >>> + cpumask_of_cpu_ptr_next(this_mask, cpu); >> 'cpu' is not declared ...
Hmm is right...! ;-)
Went through my logs and didn't see the file explicitly listed as compiled but it still should have caught it.
Thanks for the fix!
> > commit 06f8d00e9eecb738c99b737ac38a585ea7583ad5 > Author: Ingo Molnar <mingo@elte.hu> > Date: Fri Jul 18 22:34:00 2008 +0200 > > cpumask: Optimize cpumask_of_cpu in lib/smp_processor_id.c, fix > > fix typo. > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > lib/smp_processor_id.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/smp_processor_id.c b/lib/smp_processor_id.c > index 9fb2df0..c4381d9 100644 > --- a/lib/smp_processor_id.c > +++ b/lib/smp_processor_id.c > @@ -23,7 +23,7 @@ notrace unsigned int debug_smp_processor_id(void) > * Kernel threads bound to a single CPU can safely use > * smp_processor_id(): > */ > - cpumask_of_cpu_ptr_next(this_mask, cpu); > + cpumask_of_cpu_ptr_next(this_mask, this_cpu); > > if (cpus_equal(current->cpus_allowed, *this_mask)) > goto out; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |