Messages in this thread | | | From | (Eric W. Biederman) | Date | Fri, 18 Jul 2008 13:07:58 -0700 | Subject | Re: [Patch] kexec: remove redundant if-else |
| |
WANG Cong <xiyou.wangcong@gmail.com> writes:
> These if-else's can be removed.
Why? That appears to be pointless code style thrashing.
Converting code with a single return into code with multiple returns. Which arguably makes it harder to prove properties about.
Further if you want to use the style you suggest a label name like err is better than the name out.
But in this case where we have multiple results I don't like the proposed change in style at all. Especially with no rational.
Eric
| |