lkml.org 
[lkml]   [2008]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 11/14] x86: Populate cpu_enabled_map
Alex Chiang wrote:
> Populate the cpu_enabled_map correctly.
>
> Note that this patch does not actually make any decisions based
> on the contents of the map.
>
> However, as the map is presented via sysfs in:
>
> /sys/devices/system/cpu/
>
> It should be populated correctly.
>
> There will be a user-visible change under the above directory.
> cpuN/ entries for firmware-disabled CPUs will now appear, whereas
> before, they did not due to a check against ACPI_MADT_ENABLED.
>
> The cpuN/ entries will be empty, and the online file in the
> above directory will reflect which CPUs are actually schedulable.
>
> Signed-off-by: Alex Chiang <achiang@hp.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: H. Peter Anvin <hpa@zytor.com>

From an x86 standpoint this patchset seems reasonable to me.

Acked-by: H. Peter Anvin <hpa@zytor.com>

Since it is a panarch patchset it presumably should go via -mm rather
than in the arch trees, so I'm not going to add it to -tip.

Obviously, if the sematics of the operations don't make sense for other
architectures -- which I will leave up to the affected maintainers --
then that should be carefully considered if the generic operations can
be done better.

-hpa


\
 
 \ /
  Last update: 2008-07-18 22:03    [W:0.580 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site