Messages in this thread | | | Date | Thu, 17 Jul 2008 16:35:40 -0700 | From | John Reiser <> | Subject | Re: [PATCH v3] elf loader support for auxvec base platform string |
| |
Andrew Morton wrote: > On Thu, 17 Jul 2008 17:19:32 -0500 > Nathan Lynch <ntl@pobox.com> wrote: > > >> [snip] >> A new aux vector entry, AT_BASE_PLATFORM, will denote the actual hardware. [snip]
> OK. > > But it conflicts directly with the already-queued > execve-filename-document-and-export-via-auxiliary-vector.patch
[snip]
It seems to me that most of the patch conflicts are mechanical and could be merged mechanically.
However I believe that the documentation change to this comment is important: ----- > #ifdef __KERNEL__ > -#define AT_VECTOR_SIZE_BASE (14 + 2) /* NEW_AUX_ENT entries in auxiliary table */ > +#define AT_VECTOR_SIZE_BASE 17 /* NEW_AUX_ENT entries in auxiliary table */ > + /* number of "#define AT_.*" above, minus {AT_NULL, AT_IGNORE, AT_NOTELF} */ > #endif ----- I scratched my head for a while to figure out that AT_NOTELF also was a subtraction as far as AT_VECTOR_SIZE_BASE was concerned.
-- John Reiser, jreiser@BitWagon.com
| |