Messages in this thread | | | Date | Fri, 18 Jul 2008 00:20:24 +0200 | From | Dominik Brodowski <> | Subject | Re: [PATCH 6/7] dynamic debug v2 - convert cpufreq |
| |
On Thu, Jul 17, 2008 at 05:46:51PM -0400, Jason Baron wrote: > Then why not just put the > > _cpufreq.h stuff in the current cpufreq.h file(s)? > > > > 1) cpufreq.h is included by other subsystems, and thus those other subsystems > potentially have the wrong debugging information.
...
> If we could pull the subsystem specific header in dynamic_printk.h for each > subsytem that would do the trick and be really clean, but i'm not sure of an > easy way to do that...
<within all cpufreq drivers> #define DYNAMIC_DEBUG_CPU_FREQ 1
<dynamic_printk.h> #ifdef DYNAMIC_DEBUG_CPU_FREQ #define DYNAMIC_DEBUG_NUM_FLAGS "3" ... #else ... ... #endif
or -- even better -- could we determine the definition of DYNAMIC_DEBUG_CPU_FREQ on the fly? It needs to be set to true for exactly all "modules" which contain a call to cpufreq_debug_printk()...
> 2) For the case where CONFIG_CPU_FREQ_DEBUG is set and > CONFIG_DYNAMIC_PRINTK_DEBUG is not set i need to be able get the proper > definition of 'dynamic_dbg_enabled()' out of dynamic_print.h (included by > kernel.h). This proper definition is obtained by setting 'DEBUG', and > thus i need to define this before the kernel.h include. > > We can solve #2 by defining an explicit definition for dynamic_dbg_enabled() > when only CONFIG_CPU_FREQ_DEBUG within cpufreq.h. roughly: > > #ifdef CONFIG_CPU_FREQ_DEBUG > #define cpufreq_debug_printk(flag) > if (cpufreq_debug & flag) > __cpufreq_debug_printk() > > However, the way i have it now I don't need two definitions for > cpufreq_debug_printk....
Not that much of a nuiseance, IMO. Or SELECT CONFIG_DYNAMIC_PRINTK_DEBUG when CONFIG_CPU_FREQ_DEBUG is enabled (if davej agrees ;) )
Best, Dominik
| |