Messages in this thread | | | Date | Thu, 17 Jul 2008 06:38:26 -0500 | From | Robin Holt <> | Subject | Re: SLUB: simplify re on_each_cpu() |
| |
On Wed, Jul 16, 2008 at 09:29:02PM +0400, Alexey Dobriyan wrote: > on_each_cpu() expands to function call on UP, too.
It looks to me like on_each_cpu is a #define for !SMP. Are you certain of the need for this change? Are you looking at a different tree than Linus'?
Thanks, Robin
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > --- > > mm/slub.c | 8 -------- > 1 file changed, 8 deletions(-) > > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1495,15 +1495,7 @@ static void flush_cpu_slab(void *d) > > static void flush_all(struct kmem_cache *s) > { > -#ifdef CONFIG_SMP > on_each_cpu(flush_cpu_slab, s, 1); > -#else > - unsigned long flags; > - > - local_irq_save(flags); > - flush_cpu_slab(s); > - local_irq_restore(flags); > -#endif > } > > /* > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |