Messages in this thread | | | Date | Thu, 17 Jul 2008 10:47:33 +0100 | From | "Will Newton" <> | Subject | Re: [PATCH 00/11] fsl_usb2_udc: A number of bug fixes and cleanups. |
| |
On Thu, Jul 17, 2008 at 10:43 AM, Li Yang <LeoLi@freescale.com> wrote: >> -----Original Message----- >> From: Will Newton [mailto:will.newton@imgtec.com] >> Sent: Tuesday, July 15, 2008 11:25 PM >> To: linux-kernel@vger.kernel.org >> Cc: linux-usb@vger.kernel.org; Li Yang; Jiang Bo; >> gregkh@suse.de; Will Newton >> Subject: [PATCH 00/11] fsl_usb2_udc: A number of bug fixes >> and cleanups. >> >> From: Will Newton <will.newton@gmail.com> >> >> Hi, >> >> These patches fix a couple of small bugs and cleanup parts of >> the fsl_usb2_udc USB gadget driver. I've split them up quite >> finely for ease of reviewing and to separate functional >> changes. Any comments would be appreciated. >> >> I would also appreciate it if someone with real Freescale >> hardware could test these changes, I'm testing this driver >> with a different SoC containing the same TDI/ARC/ChipIdea IP block. > > Thanks for the patches. Looks like they are ok, but I still need to > test them later. > > What's the SoC you have tested with the driver? Maybe you could also > update the Kconfig for that.
It's actually one of these:
http://www.frontier-silicon.com/products/chips/chorus2.htm
Support for which is not yet in the mainline kernel. Kconfig updates should follow when the SoC support is merged but I hope these patches all make sense for any chip using this IP.
> - Leo >> >> Thanks, >> >> Will Newton (11): >> fsl_usb2_udc: Make dr_ep_setup function static. >> fsl_usb2_udc: Remove check for udc == NULL in dr_controller_setup. >> fsl_usb2_udc: Fix some sparse warnings and remove redundant code. >> fsl_usb2_udc: Clean up whitespace in errors and warnings. >> fsl_usb2_udc: Clean up whitespace in /proc debugging output. >> fsl_usb2_udc: Initialize spinlock earlier. >> fsl_usb2_udc: Rename the arguments of the fsl_writel macro. >> fsl_usb2_udc: Uninline udc_reset_ep_queue. >> fsl_usb2_udc: Make fsl_queue_td return type void. >> fsl_usb2_udc: Add a wmb before priming endpoint. >> fsl_usb2_udc: Fix oops on probe failure. >> >> drivers/usb/gadget/fsl_usb2_udc.c | 176 >> ++++++++++++++++-------------------- >> drivers/usb/gadget/fsl_usb2_udc.h | 21 +---- >> 2 files changed, 80 insertions(+), 117 deletions(-) >> >> - >> This message is subject to Imagination Technologies' e-mail >> terms: http://www.imgtec.com/e-mail.htm >> - >> >> >
| |