Messages in this thread | | | Date | Thu, 17 Jul 2008 12:40:14 +0900 | From | Hidetoshi Seto <> | Subject | Re: [PATCH] stopmachine: add stopmachine_timeout v2 |
| |
Jeremy Fitzhardinge wrote: > Hidetoshi Seto wrote: >> +#ifdef CONFIG_STOP_MACHINE >> +extern unsigned long stopmachine_timeout; >> +#endif > > No externs in C files. Put it in an appropriate header.
sysctl.c already has many externs... but I can fix at least the above.
> I'll do a proper review soon.
Is it better to postpone v4 until your comment comes?
Thanks, H.Seto
| |