lkml.org 
[lkml]   [2008]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver
On Thursday, July 17, 2008 12:36 AM
Roland Dreier <rdreier@cisco.com> wrote:
>
> > Output of checkpatch (scripts/checkpatch.pl in kernel source).
> > Personally, I am not a whitespace bigot, and don't think
> > all the warnings in checkpatch have to be fixed.
> >
> > ----------
> > ERROR: patch seems to be corrupt (line wrapped?) > #121:
> FILE: drivers/net/atl1e/atl1e.h:9:
> > ree
> >
> > WARNING: space prohibited between function name and open
> parenthesis '('
> > #212: FILE: drivers/net/atl1e/atl1e.h:97:
> > + _tpd =3D (((_vlan) << (4)) | (((_vlan) >> 13) & 7) |\
>
> It's kind of pointless to run checkpatch on a corrupted patch
> (the email was quoted-printable and you didn't decode it back
> to text). Of course it's also better to send non-mangled patches.
>
> - R.
>

Hi, Roland
I used outlook to send these patches, can you give me some
aderise on how to send non-mangled patches.

Best wishes
jie


\
 
 \ /
  Last update: 2008-07-17 04:51    [W:0.535 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site