Messages in this thread | | | Date | Wed, 16 Jul 2008 13:43:27 -0700 | From | Joel Becker <> | Subject | Re: [BUGFIX][PATCH v2 0/2] configfs: Fix cleanup after mkdir() failure |
| |
On Wed, Jul 16, 2008 at 07:56:54PM +0200, Louis Rilling wrote: > On Wed, Jul 16, 2008 at 10:27:03AM -0700, Joel Becker wrote: > > On Wed, Jul 16, 2008 at 03:08:21PM +0200, Louis Rilling wrote: > > > - error handling in config_*_init_type_name(): has rather low priority in my > > > TODO list, will come back to it probably in a few weeks. > > > > I thought we did this already. Perhaps I didn't include it? > > Did we have another change to make? > > You requested me to move a BUG_ON() earlier (before the actual memory > allocation), and to update documentation. I'm quite in a hurry on other things, > so I'm delaying this (especially the documentation part for which I feel like a > new paragraph is needed).
Sounds good.
> > > - a small locking cleanup in configfs_rmdir(): will do at the same time as > > > lockdep stuff. > > > > What sort of change? I suppose I'll see it when it arrives. > > You may look at the retry loop in configfs_rmdir() and see that locks need only > to be taken inside the loop, not outside. This would result in fewer lines for > exactly the same behavior.
I see what you mean. Not pressing, I agree.
> > I figure this new stuff will probably miss the .27 window, but > > it sounds like that's fine - nothing too serious, and it will make .28. > > Sorry for not being responsive enough. As mentioned above, I have more urgent > things to work on right now.
Don't worry, do what you have to do. We're good for .27 - the major races have been fixed. Thank you for all your work!
Joel
--
Life's Little Instruction Book #451
"Don't be afraid to say, 'I'm sorry.'"
Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |