Messages in this thread | | | Subject | Re: [patch 10/17] LTTng instrumentation - swap | From | Peter Zijlstra <> | Date | Wed, 16 Jul 2008 16:47:34 +0200 |
| |
On Wed, 2008-07-16 at 10:40 -0400, Mathieu Desnoyers wrote: > * Peter Zijlstra (peterz@infradead.org) wrote: > > On Tue, 2008-07-15 at 18:26 -0400, Mathieu Desnoyers wrote:
> > > @@ -1796,6 +1799,7 @@ get_swap_info_struct(unsigned type) > > > { > > > return &swap_info[type]; > > > } > > > +EXPORT_SYMBOL_GPL(get_swap_info_struct); > > > > I'm not too happy with this export. > > > > Would it make more sense to turn get_swap_info_struct into a static > inline in swap.h ?
Seeing a consumer of it would go a long way towards discussing it ;-)
| |