Messages in this thread | | | From | Michael Buesch <> | Subject | Re: [PATCH] Add SPI over GPIO driver | Date | Tue, 15 Jul 2008 14:52:13 +0200 |
| |
On Monday 14 July 2008 22:43:45 Andrew Morton wrote: > On Mon, 14 Jul 2008 21:09:12 +0200 > Michael Buesch <mb@bu3sch.de> wrote: > > > +static inline void do_spidelay(struct spi_device *dev, unsigned nsecs) > > +{ > > + struct spi_gpio *sp = spidev_to_sg(dev); > > + > > + if (!sp->info->no_spi_delay) > > + ndelay(nsecs); > > +} > > + > > +#define spidelay(nsecs) do { \ > > + /* Steal the spi_device pointer from our caller. \ > > + * The bitbang-API should probably get fixed here... */ \ > > + do_spidelay(spi, nsecs); \ > > + } while (0) > > A macro which requires that its caller have a particular local variable > is a bit nasty. Could we plan to add the spi_device* to spidelay() > please?
Yeah right. I was planning to fix this later on _after_ this was merged. This makes the merge easier with less patch cross-dependencies.
-- Greetings Michael.
| |