lkml.org 
[lkml]   [2008]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Set_up irq problem while using gpio
On Tue, Jul 15, 2008 at 11:34:23AM +0530, sasa sasa wrote:
> Hi,
>
> I have query that the below patch has to applied on irq/manage.c file or not.
> --- kernel_old/irq/manage.c 2008-02-07 22:11:14.000000000 +0530
> +++ kernel_new/irq/manage.c 2008-02-07 22:19:14.000000000 +0530
> @@ -349,8 +349,14 @@
> /* Setup the type (level, edge polarity) if configured: */
> if (new->flags & IRQF_TRIGGER_MASK) {
> if (desc->chip && desc->chip->set_type)
> - desc->chip->set_type(irq,
> - new->flags & IRQF_TRIGGER_MASK);
> + {
> + if((desc->chip->set_type(irq,
> + new->flags & IRQF_TRIGGER_MASK)))
> + {
> + spin_unlock_irqrestore(&desc->lock, flags);
> + return -ESPIPE;
> + }
> + }

this is difficult to read, a better way would be to

ret = desc->chip->set_type(irq, new->flags & IRQF_TRIGGER_MASK)
if (ret) {
spin_unlock_irqrestore(&desc->lock, flags);
return ret;
}


If set_type() is meant to return an error, this should have been done
from the start, instead of being ignored.

tbh, the code could be further cleaned up by holding
the (new->flags & IRQF_TRIGGER_MASK in a variable such as new_trigger
which would stop the problem of wrapping lines...

> The reason is that in case of gpio pins used as interrupt pin but that
> pin has already been ocuupied in other mode (like alternate function
> mode or in software mode) by other device. In that case, some error
> mechanism must be there, if we are requesting that gpio pin as
> interrupt through request_irq function.

Hmm, I thought (when implementing the s3c24xx irq support) that
requesting the IRQ should change the pin mode appropriately.

--
Ben (ben@fluff.org, http://www.fluff.org/)

'a smiley only costs 4 bytes'


\
 
 \ /
  Last update: 2008-07-15 14:35    [W:1.141 / U:3.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site