Messages in this thread | | | Date | Mon, 14 Jul 2008 14:50:18 -0500 | From | Robin Holt <> | Subject | Re: [PATCH] - GRU virtual -> physical translation |
| |
On Mon, Jul 14, 2008 at 11:31:07AM -0500, Jack Steiner wrote: > On Mon, Jul 14, 2008 at 09:24:51AM -0700, Andrew Morton wrote: > > On Mon, 14 Jul 2008 09:52:55 -0500 Jack Steiner <steiner@sgi.com> wrote: > > > > > On Fri, Jul 11, 2008 at 12:17:36PM -0700, Andrew Morton wrote: > > > > On Wed, 9 Jul 2008 14:14:39 -0500 Jack Steiner <steiner@sgi.com> wrote: > > > > > > > > > Open code the equivalent to follow_page(). This eliminates the > > > > > requirement for an EXPORT of follow_page(). > > > > > > > > I'd prefer to export follow_page() - copying-n-pasting just to avoid > > > > exporting the darn thing is silly. > > > > > > If follow_page() can be EXPORTed, I think that may make the most sense for > > > now. > > > > What was Christoph's reason for objecting to the export? > > No clue. Just a NACK. > > Christoph???
Maybe I missed part of the discussion, but I thought follow_page() would not work because you need this to function in the interrupt context and locks would then need to be made irqsave/irqrestore.
This, of course does not in any way answer the question about why follow_page() can not be exported.
Thanks, Robin
| |