lkml.org 
[lkml]   [2008]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] advansys: use request_firmware
From
Date
On Mon, 2008-07-14 at 08:50 -0600, Matthew Wilcox wrote:
> I'm not quite sure whether my question was answered ...
>
> When firmware is built in, does
> 1) request_firmware() make a copy of it and then release_firmware free
> that copy?
> 2) request_firmware() return a pointer to the built-in firmware with
> release_firmware() being a no-op?
> 3) request_firmware() return a pointer to the built-in firmware with
> release_firmware() freeing the original?
>
> Cases 1 and 2 are fine, case 3 is a problem.

Effectively (2).

Actually we do allocate and free the 'struct firmware' but fw->data is
just pointed to the original blob, and then that blob doesn't get freed.

--
dwmw2



\
 
 \ /
  Last update: 2008-07-14 16:59    [W:0.041 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site