lkml.org 
[lkml]   [2008]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [bisected] kernel panic 2.6.22 -> 2.6.26-rc9+
    From
    Date
    Andrew Morton <akpm@linux-foundation.org> writes:

    > --- a/include/asm-arm/bitops.h~a
    > +++ a/include/asm-arm/bitops.h
    > @@ -277,9 +277,16 @@ static inline int constant_fls(int x)
    > * the clz instruction for much better code efficiency.
    > */
    >
    > -#define fls(x) \
    > +#define __fls(x) \
    > ( __builtin_constant_p(x) ? constant_fls(x) : \
    > ({ int __r; asm("clz\t%0, %1" : "=r"(__r) : "r"(x) : "cc"); 32-__r; }) )
    > +
    > +/* Implement fls() in C so that 64-bit args are suitably truncated */
    > +static inline int fls(int x)
    > +{
    > + return __fls(x);
    > +}
    > +

    Well, I like it more as it fixes all possible places instead of only
    fls64().

    But... can't we just move the #define body into the inline fls(x)?
    Will there be other users of __fls(x)? It seems the
    __builtin_constant_p(x) works for inline functions.

    The above patch fixes the kernel panic, too.
    --
    Krzysztof Halasa


    \
     
     \ /
      Last update: 2008-07-13 23:53    [W:3.587 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site