Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [patch 5/5] x86 PCI: use dev_printk when possible | Date | Tue, 1 Jul 2008 18:57:41 -0700 |
| |
On Monday, June 30, 2008 4:57 pm Andrew Morton wrote: > On Fri, 13 Jun 2008 10:52:14 -0600 > > Bjorn Helgaas <bjorn.helgaas@hp.com> wrote: > > I converted DBG() to dev_dbg(). This DBG() is from arch/x86/pci/pci.h > > and requires source-code modification to enable, so dev_dbg() seems > > roughly equivalent. > > > > The printks in arch/x86/pci/irq.c were a little hairy, with lines > > printed in several pieces. I straightened it out a little, but > > another set of eyes would be good. > > > > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com> > > > > --- > > arch/x86/pci/fixup.c | 3 + > > arch/x86/pci/i386.c | 26 ++++++-------- > > arch/x86/pci/irq.c | 91 > > ++++++++++++++++++++++----------------------------- arch/x86/pci/numa.c > > | 5 +- > > Got a bunch of rejects in arch/x86/pci/irq.c due to pending whitespace > fixes. I fixed a couple of them but then I got bored, so the > conversion in there is only partial. > > Please prefer to raise patches against linux-next if poss, especially > during late -rc's.
Yeah, the x86 tree(s) move too fast for me to keep up with. The change seems worthwhile though, maybe Ingo or one of the x86 team could just search & replace?
Jesse
| |