lkml.org 
[lkml]   [2008]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: update mptable v7 - fix
On Mon, 9 Jun 2008, Ingo Molnar wrote:

> here's the condition:
>
> config X86_MPPARSE
> def_bool y
> depends on (X86_32 && (X86_LOCAL_APIC && !X86_VISWS)) || X86_64
>
> 64-bit has it unconditionally, 32-bit has it on SMP, UP-IOAPIC or
> UP-local-APIC mode. [ (and VISWS is an ugly complication we should try
> to eradicate similarly to NUMAQ, if possible :-) ]

Given X86_64 selects X86_LOCAL_APIC I am not sure the redundancy seen
above does not actually obscure the logic behind... I think:

depends on X86_LOCAL_APIC && !X86_VISWS

would be clearer and get the same.

Maciej


\
 
 \ /
  Last update: 2008-06-09 21:53    [W:0.077 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site