Messages in this thread | | | Date | Mon, 9 Jun 2008 20:49:46 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH] x86: update mptable v7 - fix |
| |
On Mon, 9 Jun 2008, Ingo Molnar wrote:
> here's the condition: > > config X86_MPPARSE > def_bool y > depends on (X86_32 && (X86_LOCAL_APIC && !X86_VISWS)) || X86_64 > > 64-bit has it unconditionally, 32-bit has it on SMP, UP-IOAPIC or > UP-local-APIC mode. [ (and VISWS is an ugly complication we should try > to eradicate similarly to NUMAQ, if possible :-) ]
Given X86_64 selects X86_LOCAL_APIC I am not sure the redundancy seen above does not actually obscure the logic behind... I think:
depends on X86_LOCAL_APIC && !X86_VISWS
would be clearer and get the same.
Maciej
| |