Messages in this thread Patch in this message | | | Subject | RE: [PATCH] spi: fix list scan success verification in PXA ssp driver | Date | Thu, 5 Jun 2008 01:45:47 -0700 | From | "Eric Miao" <> |
| |
Acked-by: Eric Miao <eric.miao@marvell.com>
And this should really go through the ARM tree, please submit the patch to RMK's patch system. Thanks.
Cheers - eric
> -----Original Message----- > From: Guennadi Liakhovetski [mailto:g.liakhovetski@pengutronix.de] > Sent: Thursday, June 05, 2008 4:37 PM > To: linux-kernel@vger.kernel.org > Cc: dbrownell@users.sourceforge.net; Eric Miao; > spi-devel-general@lists.sourceforge.net > Subject: [PATCH] spi: fix list scan success verification in PXA ssp driver > > The list search success check in arch/arm/mach-pxa/ssp.c is wrong: for > example, it didn't recognise failure for me when I requested port 0. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@pengutronix.de> > > --- > > arch/arm/mach-pxa/ssp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/arch/arm/mach-pxa/ssp.c > =================================================================== > --- linux-2.6.orig/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:26.000000000 > +0200 > +++ linux-2.6/arch/arm/mach-pxa/ssp.c 2008-06-04 12:11:50.000000000 +0200 > @@ -330,7 +330,7 @@ > > mutex_unlock(&ssp_lock); > > - if (ssp->port_id != port) > + if (&ssp->node == &ssp_list) > return NULL; > > return ssp;
| |