Messages in this thread | | | Date | Thu, 05 Jun 2008 17:31:50 +0900 | From | Yasunori Goto <> | Subject | Re: [PATCH -mm 11/14] bootmem: respect goal more likely |
| |
I gotcha! :-)
max -= PFN_DOWN(bdata->node_boot_start); start -= PFN_DOWN(bdata->node_boot_start); + fallback -= PFN_DOWN(bdata->node_boot_start);
if (bdata->last_success > start) { - /* Set goal here to trigger a retry on failure */ - start = goal = ALIGN(bdata->last_success, step); + fallback = start; -------------------------------- (*) + start = ALIGN(bdata->last_success, step); }
(*) is root cause. "fallback" is set as 0, because start is index of bitmap at here. When normal zone is allocated first, and DMA zone is required by alloc_bootmem_low() later and first page is free yet, fallback is set as 0.
+ if (fallback) { + start = ALIGN(fallback, step); + fallback = 0; + goto find_block; + } +
As a result, this retry code is skipped, and alloc_bootmem_low() fails. So, when I change here from fallback to a retry_flag, my box can boot up.
Thanks. -- Yasunori Goto
| |